Add blackbody PBR node implementations#1367
Add blackbody PBR node implementations#1367jstone-lucasfilm merged 7 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Fix blackbody node MaterialXGen tests.
|
This looks really promising, thanks @nicolassavva-autodesk. Let us know if you run into any issues with the Autodesk CLA, and the Linux Foundation is usually very responsive if you file a support ticket using the link above. |
|
Thanks Jonathan |
|
Looks great @nicolassavva-autodesk , I just noted an issue with the clamps above. |
|
Good catch Niklas. |
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks great, thanks @nicolassavva-autodesk. My one recommendation would be to move the example material from the Standard Surface examples folder to the test suite, where it would be a better fit:
https://github.com/AcademySoftwareFoundation/MaterialX/tree/main/resources/Materials/TestSuite/pbrlib/bsdf
The example material could additionally be simplified to a simple nodegraph containing the blackbody node, rather than making it a Standard Surface material with pure emission.
jstone-lucasfilm
changed the title
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @nicolassavva-autodesk!
|
is there an MDL implementation missing now? |
|
I hope I'm not opening a can of worms on a topic that has long since been settled, but is this function merely trying to return the color corresponding to a blackbody temperature, normalized to some standard luminance? Or is it supposed to be returning the actual emittance of the blackbody (W/m^2 or whatever)? |
Address the missing targets for the PBR blackbody node implementation using the following approximation: Wikipedia: Planckian Locus Approximation Add a simple unlit surface material example using the above blackbody node for emission. Reenable blackbody node tests.
6 participants
Address the missing targets for the PBR blackbody node implementation ( #1356 )
using the following approximation: Wikipedia: Planckian Locus Approximation
Add a simple Standard Surface material example using the above blackbody node for emission.
Reenable blackbody node tests.